Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pipelunerun provenance when multiple tasks have the same name (ca… #1169

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix pipelunerun provenance when multiple tasks have the same name (ca… #1169

merged 1 commit into from
Jul 31, 2024

Conversation

jkhelil
Copy link
Member

@jkhelil jkhelil commented Jul 31, 2024 •
edited
Loading

…se of use of matrix to fan out tasks on a pipeline)

Changes

Chains only generates provenance attestations for the first image in a matrix of TaskRuns, while all images are signed. The issue is rooted in the assumption that PipelineTaskRuns have unique names within a Pipeline, which isn't true when a matrix is used. The PR aims to address this by ensuring that provenance attestations are generated for all images in the matrix.

  • Updated the provenance generation logic to handle multiple TaskRuns with the same task name.
  • Ensured that provenance attestations are created for all images referenced in matrixed TaskRuns.

fixes #1164

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 31, 2024
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/extract/extract.go 67.4% 66.7% -0.8
pkg/chains/formats/slsa/extract/v1beta1/extract.go 61.5% 60.9% -0.7
pkg/chains/formats/slsa/internal/material/material.go 92.9% 91.0% -1.9
pkg/chains/formats/slsa/internal/material/v1beta1/material.go 92.3% 90.2% -2.1
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 85.7% 84.7% -1.0
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 73.2% 72.0% -1.2
pkg/chains/objects/objects.go 24.3% 24.2% -0.1

@jkhelil
fix pipelunerun provenance when multiple tasks have the same name (ca…
0c67ea9 
…se of use of matrix to fan out tasks on a pipeline)
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/slsa/extract/extract.go 67.4% 66.7% -0.8
pkg/chains/formats/slsa/extract/v1beta1/extract.go 61.5% 60.9% -0.7
pkg/chains/formats/slsa/internal/material/material.go 92.9% 91.0% -1.9
pkg/chains/formats/slsa/internal/material/v1beta1/material.go 92.3% 90.2% -2.1
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 85.7% 84.7% -1.0
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 73.2% 72.0% -1.2
pkg/chains/objects/objects.go 24.3% 24.2% -0.1

lcarva
lcarva approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@tekton-robot tekton-robot merged commit 57f0e8f into tektoncd:main Jul 31, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcarva lcarva lcarva approved these changes

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@lcarva lcarva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chains does not generate provenance for images built in a matrix
3 participants
@jkhelil @tekton-robot @lcarva